forked from mirrors/forgejo
Currently authentication methods return information in two forms: they return who was authenticated as a `*user_model.User`, and then they insert key-values into `ctx.Data` which has critical impact on how the authenticated request is treated. This PR changes the authentication methods to return structured data in the form of an `AuthenticationResult`, with all the key-value information in `ctx.Data` being moved into methods on the `AuthenticationResult` interface. Authentication workflows in Forgejo are a real mess. This is the first step in trying to clean it up and make the code predictable and reasonable, and is both follow-up work that was identified from the repo-specific access tokens (where the `"ApiTokenReducer"` key-value was added), and is pre-requisite work to future JWT enhancements that are [being discussed](https://codeberg.org/forgejo/forgejo/issues/3571#issuecomment-13268004). ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - All changes, at least in theory, are refactors of existing logic and are not expected to have functional deviations -- existing regression tests are the only planned testing. - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12202 Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org>
110 lines
3.5 KiB
Go
110 lines
3.5 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package method
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
actions_model "forgejo.org/models/actions"
|
|
"forgejo.org/models/auth"
|
|
"forgejo.org/models/unittest"
|
|
user_model "forgejo.org/models/user"
|
|
"forgejo.org/services/actions"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestUserIDFromToken(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
t.Run("Actions JWT", func(t *testing.T) {
|
|
const RunningTaskID = 47
|
|
task := &actions_model.ActionTask{
|
|
ID: RunningTaskID,
|
|
Job: &actions_model.ActionRunJob{
|
|
ID: 2,
|
|
RunID: 1,
|
|
},
|
|
}
|
|
token, err := actions.CreateAuthorizationToken(task, map[string]any{}, false)
|
|
require.NoError(t, err)
|
|
|
|
o := OAuth2{}
|
|
authResult, err := o.userIDFromToken(t.Context(), token)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, int64(user_model.ActionsUserID), authResult.User().ID)
|
|
isActionsToken, authTaskID := authResult.ActionsTaskID().Get()
|
|
assert.True(t, isActionsToken)
|
|
assert.Equal(t, int64(RunningTaskID), authTaskID)
|
|
})
|
|
|
|
t.Run("Actions error-JWT", func(t *testing.T) {
|
|
cases := map[string]struct {
|
|
Token string
|
|
Error error
|
|
}{
|
|
"Empty": {"", auth.ErrAccessTokenEmpty{}},
|
|
"To short": {"abc", auth.ErrAccessTokenNotExist{Token: "abc"}},
|
|
}
|
|
|
|
o := OAuth2{}
|
|
for name, c := range cases {
|
|
t.Run(name, func(t *testing.T) {
|
|
authResult, err := o.userIDFromToken(t.Context(), c.Token)
|
|
require.ErrorIs(t, err, c.Error)
|
|
assert.Nil(t, authResult)
|
|
})
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestCheckTaskIsRunning(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
cases := map[string]struct {
|
|
TaskID int64
|
|
Expected bool
|
|
}{
|
|
"Running": {TaskID: 47, Expected: true},
|
|
"Missing": {TaskID: 1, Expected: false},
|
|
"Cancelled": {TaskID: 46, Expected: false},
|
|
}
|
|
|
|
for name := range cases {
|
|
c := cases[name]
|
|
t.Run(name, func(t *testing.T) {
|
|
actual := CheckTaskIsRunning(t.Context(), c.TaskID)
|
|
assert.Equal(t, c.Expected, actual)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseToken(t *testing.T) {
|
|
cases := map[string]struct {
|
|
Header string
|
|
ExpectedToken string
|
|
Expected bool
|
|
}{
|
|
"Token Uppercase": {Header: "Token 1234567890123456789012345687901325467890", ExpectedToken: "1234567890123456789012345687901325467890", Expected: true},
|
|
"Token Lowercase": {Header: "token 1234567890123456789012345687901325467890", ExpectedToken: "1234567890123456789012345687901325467890", Expected: true},
|
|
"Token Unicode": {Header: "to\u212Aen 1234567890123456789012345687901325467890", ExpectedToken: "", Expected: false},
|
|
"Bearer Uppercase": {Header: "Bearer 1234567890123456789012345687901325467890", ExpectedToken: "1234567890123456789012345687901325467890", Expected: true},
|
|
"Bearer Lowercase": {Header: "bearer 1234567890123456789012345687901325467890", ExpectedToken: "1234567890123456789012345687901325467890", Expected: true},
|
|
"Missing type": {Header: "1234567890123456789012345687901325467890", ExpectedToken: "", Expected: false},
|
|
"Three Parts": {Header: "abc 1234567890 test", ExpectedToken: "", Expected: false},
|
|
"Token Three Parts": {Header: "Token 1234567890 test", ExpectedToken: "", Expected: false},
|
|
}
|
|
|
|
for name := range cases {
|
|
c := cases[name]
|
|
t.Run(name, func(t *testing.T) {
|
|
req, _ := http.NewRequest("GET", "/", nil)
|
|
req.Header.Add("Authorization", c.Header)
|
|
ActualToken, ActualSuccess := parseToken(req)
|
|
assert.Equal(t, c.ExpectedToken, ActualToken)
|
|
assert.Equal(t, c.Expected, ActualSuccess)
|
|
})
|
|
}
|
|
}
|