forked from mirrors/forgejo
edc6072da2
Fix regression of https://codeberg.org/forgejo/forgejo/pulls/5589 & https://codeberg.org/forgejo/forgejo/pulls/7006. Both added invisible input fields with `required` attribute into the forms used for creating issues and adding comments via `combomarkdowneditor.tmpl`. These fields were not related to the form and were only used for the modal dialogs. * When JS is on, modals are moved out of the form to the bottom of the page by JS that handles modals * When JS is off, the forms are stuck with invisible inputs preventing form submission * Another side effect is that request data contains these unwanted fields This was fixed by adding attribute `disabled` to unwanted inputs. Then JS removes it on initialization. Thanks to @Beowulf for helping with choosing the approach! When a field is `disabled`, the browser doesn't consider it in form validation and doesn't even include it in the request data. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9614 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: Beowulf <beowulf@beocode.eu> |
||
|---|---|---|
| .. | ||
| components | ||
| features | ||
| markup | ||
| modules | ||
| render | ||
| standalone | ||
| utils | ||
| vendor | ||
| webcomponents | ||
| bootstrap.js | ||
| bootstrap.test.js | ||
| emoji.test.js | ||
| htmx.js | ||
| index.js | ||
| jquery.js | ||
| svg.js | ||
| svg.test.js | ||
| types.d.ts | ||
| utils.js | ||
| utils.test.js | ||
| vitest.setup.js | ||