misskey/packages
SASAPIYO (SASAGAWA Kiyoshi) ae5d2d40d7
fix(backend): skip inbox activities without an actor instead of throwing TypeError (#17558)
* fix(backend): skip inbox activities without an actor instead of throwing TypeError

- guard getApId() against null/undefined (and fix the 'detemine' typo)
- skip actor-less inbox activities early with Bull.UnrecoverableError

Fixes #17557

* fix(backend): reject actor-less inbox activities at enqueue time

Per review feedback (#17558), move the actor presence check to the inbox
HTTP handler and drop the processor-side guard.

- ActivityPubServerService.inbox(): validate the request body from the
  loose (unknown) type and return 400 for structurally invalid activities
  (non-object / missing actor) instead of enqueueing a job that can never
  be authenticated. Avoids useless retries and TypeError noise.
- InboxProcessorService.process(): remove the actor null guard; IActivity.actor
  is non-null, so the check is unnecessary once enqueue is validated.
- getApId(): widen the parameter to include undefined so the existing null
  guard is type-honest (getOneApId can pass value[0] of an empty array).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-19 15:00:17 +09:00
..
backend fix(backend): skip inbox activities without an actor instead of throwing TypeError (#17558) 2026-06-19 15:00:17 +09:00
frontend fix(frontend): ノートの下書きをリセットする際、未アップロードのファイルについては添付予定が解除されない問題を修正 (#17568) 2026-06-17 14:26:45 +09:00
frontend-builder deps: update dependencies (#17575) 2026-06-17 12:13:50 +09:00
frontend-embed deps: update dependencies (#17575) 2026-06-17 12:13:50 +09:00
frontend-shared deps: update dependencies (#17575) 2026-06-17 12:13:50 +09:00
i18n deps: update dependencies (#17575) 2026-06-17 12:13:50 +09:00
icons-subsetter deps: update dependencies (#17575) 2026-06-17 12:13:50 +09:00
misskey-bubble-game deps: update dependencies (#17575) 2026-06-17 12:13:50 +09:00
misskey-js Bump version to 2026.6.0-beta.0 2026-06-17 03:21:46 +00:00
misskey-reversi deps: update dependencies (#17575) 2026-06-17 12:13:50 +09:00
shared enable and fix no-unused-vars and no-async-promise-executor (#17070) 2026-01-08 11:49:12 +09:00
sw deps: update dependencies (#17575) 2026-06-17 12:13:50 +09:00
meta.json