FIX: Changing the extensions for a highlighter and clicking Apply doesn't save them (fixes #2182)

(cherry picked from commit a2d8afae68)

src/frames/foptionseditorcolors.lfm

@@ -55,9 +55,10 @@ inherited frmOptionsEditorColors: TfrmOptionsEditorColors
         Width = 305
         Align = alClient
         TabOrder = 0
+        OnChange = edtFileExtensionsChange
       end
       object btnResetMask: TSpeedButton
-        Left = 328
+        Left = 317
         Height = 23
         Hint = 'Reset'
         Top = 0
@@ -101,51 +102,6 @@ inherited frmOptionsEditorColors: TfrmOptionsEditorColors
         }
         OnClick = btnResetMaskClick
       end
-      object btnSaveMask: TSpeedButton
-        Left = 305
-        Height = 23
-        Hint = 'Save'
-        Top = 0
-        Width = 23
-        Align = alRight
-        Glyph.Data = {
-          36040000424D3604000000000000360000002800000010000000100000000100
-          2000000000000004000064000000640000000000000000000000BA6A368FB969
-          35B5B86935EEB76835FFB56835FFB46734FFB26634FFB06533FFAE6433FFAC63
-          32FFAA6232FFA96132FFA86031FFA76031FEA66031F1A86131C4BA6A35DEEBC6
-          ADFFEAC5ADFFFEFBF8FFFEFBF8FFFEFBF8FFFEFBF8FFFEFBF8FFFEFBF8FFFEFB
-          F8FFFEFBF8FFFEFBF8FFFEFBF8FFC89A7CFFC79879FFA76031EDBA6B37FEEDCA
-          B3FFE0A27AFFFEFAF7FF62C088FF62C088FF62C088FF62C088FF62C088FF62C0
-          88FF62C088FF62C088FFFDF9F6FFCA8D65FFC99B7CFFA76031FEBB6C38FFEECC
-          B6FFE1A27AFFFEFAF7FFBFDCC2FFBFDCC2FFBFDCC2FFBFDCC2FFBFDCC2FFBFDC
-          C2FFBFDCC2FFBFDCC2FFFDF9F6FFCD9068FFCC9E81FFA86132FFBB6B38FFEFCE
-          B8FFE1A279FFFEFAF7FF62C088FF62C088FF62C088FF62C088FF62C088FF62C0
-          88FF62C088FF62C088FFFDF9F6FFCF936AFFCEA384FFAA6132FFBA6A36FFEFD0
-          BBFFE2A27AFFFEFBF8FFFEFBF8FFFEFBF8FFFEFBF8FFFEFBF8FFFEFBF8FFFEFB
-          F8FFFEFBF8FFFEFBF8FFFEFBF8FFD3966DFFD2A78AFFAB6232FFBB6A36FFF0D2
-          BEFFE2A37AFFE2A37AFFE1A37AFFE2A37BFFE1A37BFFE0A178FFDE9F77FFDD9F
-          76FFDC9D74FFD99B72FFD89971FFD69970FFD5AB8EFFAD6333FFBB6A36FFF2D5
-          C2FFE3A37AFFE3A37AFFE2A37BFFE2A37BFFE2A47BFFE1A279FFE0A178FFDEA0
-          77FFDE9E75FFDC9D74FFDA9B73FFD99B73FFDAB095FFAF6433FFBB6A36FFF2D8
-          C5FFE3A47BFFE3A37AFFE3A47AFFE2A47BFFE2A37BFFE1A37BFFE1A279FFDFA0
-          77FFDE9F76FFDD9E74FFDB9C72FFDC9D74FFDDB59AFFB16534FFBB6B36FFF4D9
-          C7FFE6A67DFFC88C64FFC98D65FFC98E67FFCB926CFFCB926DFFCA9069FFC88C
-          65FFC88C64FFC88C64FFC88C64FFDA9C74FFE1BA9FFFB36634FFBB6B36FEF4DC
-          C9FFE7A77DFFF9ECE1FFF9ECE1FFF9EDE3FFFCF4EEFFFDFAF7FFFDF7F3FFFAED
-          E5FFF7E7DBFFF7E5D9FFF6E5D8FFDEA077FFE4BEA4FFB46734FFBC6B36FAF5DD
-          CCFFE7A87EFFFAF0E8FFFAF0E8FFC98D66FFFAF0E9FFFDF8F3FFFEFAF8FFFCF4
-          EFFFF9E9DFFFF7E7DBFFF7E5D9FFE0A278FFE7C2A9FFB66835FFBC6B36F0F6DF
-          D0FFE8A87EFFFCF6F1FFFCF6F1FFC88C64FFFAF1E9FFFBF4EEFFFDFAF7FFFDF9
-          F6FFFAF0E8FFF8E8DDFFF7E6DBFFE1A37AFFEFD5C3FFB76935FEBC6B36D8F6DF
-          D1FFE9AA80FFFEFAF6FFFDFAF6FFC88C64FFFBF3EEFFFBF1EAFFFCF6F2FFFEFB
-          F8FFFCF6F1FFF9ECE2FFF8E7DBFFEED0BAFFECD0BDFFBB703EF8BC6B369BF6E0
-          D1FFF7E0D1FFFEFBF8FFFEFBF7FFFDF9F6FFFCF5F0FFFAF0EAFFFBF2EDFFFDF9
-          F6FFFDFAF7FFFBF1EBFFF8E9DFFEECD0BDFBC9895EECB5693563BC6B3671BC6B
-          3690BC6B36CCBC6B36EEBC6B36FABB6B36FEBB6B36FFBB6A36FFBB6A36FFBC6C
-          39FFBD6E3BFFBB6D3AFFBB6B38EFBB703ECBB6693554FFFFFF00
-        }
-        OnClick = btnSaveMaskClick
-      end
     end
   end
   object PnlTop2: TPanel[1]
@@ -574,7 +530,6 @@ inherited frmOptionsEditorColors: TfrmOptionsEditorColors
       Top = 0
       Width = 205
       Align = alLeft
-      DefaultItemHeight = 18
       ReadOnly = True
       RowSelect = True
       ScrollBars = ssAutoBoth

src/frames/foptionseditorcolors.lrj

@@ -1,6 +1,5 @@
 {"version":1,"strings":[
 {"hash":5818820,"name":"tfrmoptionseditorcolors.btnresetmask.hint","sourcebytes":[82,101,115,101,116],"value":"Reset"},
-{"hash":366789,"name":"tfrmoptionseditorcolors.btnsavemask.hint","sourcebytes":[83,97,118,101],"value":"Save"},
 {"hash":195459012,"name":"tfrmoptionseditorcolors.foregroundlabel.caption","sourcebytes":[70,111,38,114,101,103,114,111,117,110,100],"value":"Fo&reground"},
 {"hash":27336596,"name":"tfrmoptionseditorcolors.backgroundlabel.caption","sourcebytes":[66,97,99,38,107,103,114,111,117,110,100],"value":"Bac&kground"},
 {"hash":195459012,"name":"tfrmoptionseditorcolors.foregroundusedefaultcheckbox.caption","sourcebytes":[70,111,38,114,101,103,114,111,117,110,100],"value":"Fo&reground"},

src/frames/foptionseditorcolors.pas

@@ -61,7 +61,6 @@ type
     pnlTop: TPanel;
     PnlTop2: TPanel;
     pnlUnderline: TPanel;
-    btnSaveMask: TSpeedButton;
     btnResetMask: TSpeedButton;
     Splitter1: TSplitter;
     pnlFileExtensions: TPanel;
@@ -90,7 +89,7 @@ type
     ToolBar1: TToolBar;
     ToolButton3: TToolButton;
     procedure btnResetMaskClick(Sender: TObject);
-    procedure btnSaveMaskClick(Sender: TObject);
+    procedure edtFileExtensionsChange(Sender: TObject);
     procedure FrameStyleBoxDrawItem(Control: TWinControl; Index: Integer;
       ARect: TRect; {%H-}State: TOwnerDrawState);
     procedure cmbLanguageChange(Sender: TObject);
@@ -236,7 +235,7 @@ begin
   end;
 end;
 
-procedure TfrmOptionsEditorColors.btnSaveMaskClick(Sender: TObject);
+procedure TfrmOptionsEditorColors.edtFileExtensionsChange(Sender: TObject);
 begin
   FCurrentHighlighter.DefaultFilter:= FCurrentHighlighter.LanguageName + ' (' + edtFileExtensions.Text + ')|' + edtFileExtensions.Text;
 end;