mirrors/doublecmd
2
0
Fork 0
mirror of https://github.com/doublecmd/doublecmd.git synced 2026-06-21 09:58:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

UPD: Improve directories display in QuickView (#759)

Browse source
This commit is contained in:
rich2014 2023-01-20 02:27:22 +08:00 • committed by GitHub
commit b0dbe66b78
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 117 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

185
src/uquickviewpanel.pas
View file

@ -42,11 +42,14 @@ type
FViewer: TfrmViewer;
FFileName: String;
private
procedure RaiseExit;
procedure LoadFile(const aFileName: String);
procedure OnChangeFileView(Sender: TObject);
procedure CreateViewer(aFileView: TFileView);
procedure FileViewChangeActiveFile(Sender: TFileView; const aFile : TFile);
function handleLinksToLocal( const Sender:TFileView; const aFile:TFile; var fullPath:String; var showMsg:String ): Boolean;
function handleNotDirect( const Sender:TFileView; const aFile:TFile; var fullPath:String; var showMsg:String ): Boolean;
function handleDirect( const Sender:TFileView; const aFile:TFile; var fullPath:String; var showMsg:String ): Boolean;
protected
procedure DoOnShowHint(HintInfo: PHintInfo) override;
public
@ -134,11 +137,6 @@ begin
TFileViewPage(FFileView.NotebookPage).OnChangeFileView:= @OnChangeFileView;
end;
procedure TQuickViewPanel.RaiseExit;
begin
raise EAbort.Create(rsSimpleWordFailedExcla);
end;
procedure TQuickViewPanel.LoadFile(const aFileName: String);
begin
if (not FFirstFile) then
@ -162,79 +160,130 @@ begin
end;
procedure TQuickViewPanel.FileViewChangeActiveFile(Sender: TFileView; const aFile: TFile);
var
fullPath: String;
showMsg: String;
begin
fullPath:= EmptyStr;
showMsg:= EmptyStr;
try
if not Assigned(aFile) then
raise EAbort.Create(rsMsgErrNotSupported);
if not handleLinksToLocal(Sender, aFile, fullPath, showMsg) then
if not handleNotDirect(Sender, aFile, fullPath, showMsg) then
handleDirect(Sender, aFile, fullPath, showMsg);
if fullPath.IsEmpty() and ShowMsg.IsEmpty() then
showMsg:= rsMsgErrNotSupported;
except
on E: EAbort do
begin
showMsg:= E.Message;
end;
end;
if not fullPath.IsEmpty() then begin
LoadFile( fullPath );
end else begin
FViewer.Hide;
FFirstFile:= True;
Caption:= showMsg;
FViewer.LoadFile(EmptyStr);
end;
end;
// return true if it should handle it, otherwise return false
// If files are links to local files
// for example: results from searching
function TQuickViewPanel.handleLinksToLocal( const Sender:TFileView; const aFile:TFile; var fullPath:String; var showMsg:String ): Boolean;
var
ActiveFile: TFile = nil;
begin
if not (fspLinksToLocalFiles in Sender.FileSource.Properties) then exit(false);
Result:= true;
if not aFile.IsNameValid then exit;
FFileSource := Sender.FileSource;
ActiveFile:= aFile.Clone;
try
if not FFileSource.GetLocalName(ActiveFile) then exit;
fullPath:= ActiveFile.FullPath;
finally
FreeAndNil(ActiveFile);
end;
end;
// return true if it should handle it, otherwise return false
// If files not directly accessible copy them to temp file source.
// for examples: ftp
function TQuickViewPanel.handleNotDirect( const Sender:TFileView; const aFile:TFile; var fullPath:String; var showMsg:String ): Boolean;
var
ActiveFile: TFile = nil;
TempFiles: TFiles = nil;
Operation: TFileSourceOperation = nil;
TempFileSource: ITempFileSystemFileSource = nil;
begin
if (fspDirectAccess in Sender.FileSource.Properties) then exit(false);
Result:= true;
if SameText(FFileName, aFile.Name) then exit;
FFileName:= aFile.Name;
if aFile.IsDirectory or aFile.IsLinkToDirectory then exit;
if not (fsoCopyOut in Sender.FileSource.GetOperationsTypes) then exit;
ActiveFile:= aFile.Clone;
TempFiles:= TFiles.Create(ActiveFile.Path);
TempFiles.Add(aFile.Clone);
try
if not (Assigned(aFile) and aFile.IsNameValid) then
raise EAbort.Create(rsMsgErrNotSupported);
if FFileSource.IsClass(TTempFileSystemFileSource) then
TempFileSource := (FFileSource as ITempFileSystemFileSource)
else
TempFileSource := TTempFileSystemFileSource.GetFileSource;
Operation := Sender.FileSource.CreateCopyOutOperation(
TempFileSource,
TempFiles,
TempFileSource.FileSystemRoot);
if not Assigned(Operation) then exit;
Sender.Enabled:= False;
try
// If files are links to local files
if (fspLinksToLocalFiles in Sender.FileSource.Properties) then
begin
if aFile.IsDirectory or aFile.IsLinkToDirectory then RaiseExit;
FFileSource := Sender.FileSource;
ActiveFile:= aFile.Clone;
if not FFileSource.GetLocalName(ActiveFile) then RaiseExit;
end
// If files not directly accessible copy them to temp file source.
else if not (fspDirectAccess in Sender.FileSource.Properties) then
begin
if aFile.IsDirectory or SameText(FFileName, aFile.Name) then RaiseExit;
if not (fsoCopyOut in Sender.FileSource.GetOperationsTypes) then RaiseExit;
ActiveFile:= aFile.Clone;
TempFiles:= TFiles.Create(ActiveFile.Path);
TempFiles.Add(aFile.Clone);
if FFileSource.IsClass(TTempFileSystemFileSource) then
TempFileSource := (FFileSource as ITempFileSystemFileSource)
else
TempFileSource := TTempFileSystemFileSource.GetFileSource;
Operation := Sender.FileSource.CreateCopyOutOperation(
TempFileSource,
TempFiles,
TempFileSource.FileSystemRoot);
if not Assigned(Operation) then RaiseExit;
Sender.Enabled:= False;
try
Operation.Execute;
finally
FreeAndNil(Operation);
Sender.Enabled:= True;
end;
FFileName:= ActiveFile.Name;
FFileSource := TempFileSource;
ActiveFile.Path:= TempFileSource.FileSystemRoot;
end
else begin
// We can use the file source directly.
FFileSource := Sender.FileSource;
ActiveFile:= aFile.Clone;
end;
LoadFile(ActiveFile.FullPath);
Operation.Execute;
finally
FreeAndNil(TempFiles);
FreeAndNil(ActiveFile);
end;
except
on E: EAbort do
begin
FViewer.Hide;
FFirstFile:= True;
Caption:= E.Message;
FViewer.LoadFile(EmptyStr);
FreeAndNil(Operation);
Sender.Enabled:= True;
end;
FFileSource := TempFileSource;
ActiveFile.Path:= TempFileSource.FileSystemRoot;
fullPath:= ActiveFile.FullPath;
finally
FreeAndNil(TempFiles);
FreeAndNil(ActiveFile);
end;
end;
// return true if it should handle it, otherwise return false
// for examples: file system
function TQuickViewPanel.handleDirect( const Sender:TFileView; const aFile:TFile; var fullPath:String; var showMsg:String ): Boolean;
var
parentDir: String;
begin
Result:= true;
FFileSource:= Sender.FileSource;
if aFile.IsNameValid then begin
fullPath:= aFile.FullPath;
end else begin
parentDir:= FFileSource.GetParentDir( aFile.Path );
if FFileSource.IsPathAtRoot(parentDir) then
showMsg:= rsPropsFolder + ': ' + parentDir
else
fullPath:= parentDir;
end;
end;