FIX: Open/Save dialogs all files filter

src/feditor.pas

@@ -930,7 +930,7 @@ var
 begin
   FormCloseQuery(Self, CanClose);
   if not CanClose then Exit;
-  dmComData.OpenDialog.Filter:= '*.*';
+  dmComData.OpenDialog.Filter:= AllFilesMask;
   if not dmComData.OpenDialog.Execute then Exit;
   if OpenFile(dmComData.OpenDialog.FileName) then
     UpdateStatus;
@@ -958,7 +958,7 @@ var
   Highlighter: TSynCustomHighlighter;
 begin
   dmComData.SaveDialog.FileName := FileName;
-  dmComData.SaveDialog.Filter:='*.*'; // rewrite for highlighter
+  dmComData.SaveDialog.Filter:= AllFilesMask; // rewrite for highlighter
   if not dmComData.SaveDialog.Execute then
     Exit;
 

src/flinker.pas

@@ -224,7 +224,7 @@ end;
 procedure TfrmLinker.FormCreate(Sender: TObject);
 begin
   InitPropStorage(Self); // Initialize property storage
-  dlgSaveAll.Filter := ParseLineToFileFilter([rsFilterAnyFiles, '*.*']);
+  dlgSaveAll.Filter := ParseLineToFileFilter([rsFilterAnyFiles, AllFilesMask]);
 end;
 
 end.

src/frames/foptionsarchivers.pas

@@ -190,8 +190,8 @@ var
 { TfrmOptionsArchivers.Init }
 procedure TfrmOptionsArchivers.Init;
 begin
-  OpenArchiverDialog.Filter := ParseLineToFileFilter([rsFilterArchiverConfigFiles, '*.ini;*.addon', rsFilterAnyFiles, '*.*']);
-  SaveArchiverDialog.Filter := ParseLineToFileFilter([rsFilterArchiverConfigFiles, '*.ini', rsFilterAnyFiles, '*.*']);
+  OpenArchiverDialog.Filter := ParseLineToFileFilter([rsFilterArchiverConfigFiles, '*.ini;*.addon', rsFilterAnyFiles, AllFilesMask]);
+  SaveArchiverDialog.Filter := ParseLineToFileFilter([rsFilterArchiverConfigFiles, '*.ini', rsFilterAnyFiles, AllFilesMask]);
 end;
 
 { TfrmOptionsArchivers.Load }

src/frames/foptionsdirectoryhotlist.pas

@@ -297,7 +297,7 @@ begin
   ParseLineToList(rsOptAddFromMainPanel, rgWhereToAdd.Items);
   ParseLineToList(rsHotDirForceSortingOrderChoices, cbSortHotDirPath.Items);
   ParseLineToList(rsHotDirForceSortingOrderChoices, cbSortHotDirTarget.Items);
-  OpenDialog.Filter := ParseLineToFileFilter([rsFilterDirectoryHotListFiles, '*.hotlist', rsFilterXmlConfigFiles, '*.xml', rsFilterAnyFiles, '*.*']);
+  OpenDialog.Filter := ParseLineToFileFilter([rsFilterDirectoryHotListFiles, '*.hotlist', rsFilterXmlConfigFiles, '*.xml', rsFilterAnyFiles, AllFilesMask]);
   SaveDialog.Filter := ParseLineToFileFilter([rsFilterDirectoryHotListFiles, '*.hotlist']);
 end;
 

src/frames/foptionsfavoritetabs.pas

@@ -169,7 +169,7 @@ begin
   ParseLineToList(rsFavTabsPanelSideSelection, cbTargetPanelRightSavedTabs.Items);
   ParseLineToList(rsFavTabsPanelSideSelection, cbExistingTabsToKeep.Items);
   ParseLineToList(rsFavTabsSaveDirHistory, cbSaveDirHistory.Items);
-  OpenDialog.Filter := ParseLineToFileFilter([rsFilterLegacyTabFiles, '*.tab', rsFilterAnyFiles, '*.*']);
+  OpenDialog.Filter := ParseLineToFileFilter([rsFilterLegacyTabFiles, '*.tab', rsFilterAnyFiles, AllFilesMask]);
 end;
 
 { TfrmOptionsFavoriteTabs.Load }

src/frames/foptionsfileassoc.pas

@@ -210,7 +210,7 @@ begin
   Exts := TExts.Create;
   FUpdatingControls := False;
   btnIconSelectFilename.Hint := sbtnIcon.Hint;
-  OpenDialog.Filter := ParseLineToFileFilter([rsFilterExecutableFiles, '*.exe;*.com;*.bat', rsFilterAnyFiles, '*.*']);
+  OpenDialog.Filter := ParseLineToFileFilter([rsFilterExecutableFiles, '*.exe;*.com;*.bat', rsFilterAnyFiles, AllFilesMask]);
 
   // The following section is to help to speed up the the user with keyboard to pass to a section to another.
   // Each TGroupBox has their caption with 1, 2, 3... with underscore under each digit.

src/frames/foptionsmisc.pas

@@ -127,8 +127,8 @@ begin
   end;
   cmbDefaultEncoding.Items.Insert(0, UpperCase(EncodingNone));
 
-  fneTCExecutableFilename.Filter := ParseLineToFileFilter([rsFilterExecutableFiles, '*.exe', rsFilterAnyFiles, '*.*']);
-  fneTCConfigFilename.Filter := ParseLineToFileFilter([rsFilterIniConfigFiles, '*.ini', rsFilterAnyFiles, '*.*']);
+  fneTCExecutableFilename.Filter := ParseLineToFileFilter([rsFilterExecutableFiles, '*.exe', rsFilterAnyFiles, AllFilesMask]);
+  fneTCConfigFilename.Filter := ParseLineToFileFilter([rsFilterIniConfigFiles, '*.ini', rsFilterAnyFiles, AllFilesMask]);
 end;
 
 procedure TfrmOptionsMisc.Load;

src/frames/foptionspluginsgroup.pas

@@ -87,13 +87,13 @@ begin
   fneLuaLibraryFilename.DialogTitle := rsOptPluginsSelectLuaLibrary;
   ParseLineToList(rsPluginFilenameStyleList, cbPluginFilenameStyle.Items);
   {$IF DEFINED(MSWINDOWS)}
-  fneLuaLibraryFilename.Filter := ParseLineToFileFilter([rsFilterLibraries, '*.dll', rsFilterAnyFiles, '*.*']);
+  fneLuaLibraryFilename.Filter := ParseLineToFileFilter([rsFilterLibraries, '*.dll', rsFilterAnyFiles, AllFilesMask]);
   {$ELSEIF DEFINED(DARWIN)}
-  fneLuaLibraryFilename.Filter := ParseLineToFileFilter([rsFilterLibraries, '*.dylib', rsFilterAnyFiles, '*.*']);
+  fneLuaLibraryFilename.Filter := ParseLineToFileFilter([rsFilterLibraries, '*.dylib', rsFilterAnyFiles, AllFilesMask]);
   {$ELSEIF DEFINED(UNIX)}
-  fneLuaLibraryFilename.Filter := ParseLineToFileFilter([rsFilterLibraries, '*.so', rsFilterAnyFiles, '*.*']);
+  fneLuaLibraryFilename.Filter := ParseLineToFileFilter([rsFilterLibraries, '*.so', rsFilterAnyFiles, AllFilesMask]);
   {$ELSE}
-  fneLuaLibraryFilename.Filter := ParseLineToFileFilter([rsFilterLibraries, '*.dll;*.dylib;*.so', rsFilterAnyFiles, '*.*']);
+  fneLuaLibraryFilename.Filter := ParseLineToFileFilter([rsFilterLibraries, '*.dll;*.dylib;*.so', rsFilterAnyFiles, AllFilesMask]);
   {$ENDIF}
   FResultForWhenWeExit := [];
 end;

src/frames/foptionstoolbarbase.pas

@@ -359,8 +359,8 @@ begin
   cbInternalCommand.Sorted := True;
   FUpdatingButtonType := True;
   ParseLineToList(rsOptToolbarButtonType, rgToolItemType.Items);
-  OpenDialog.Filter := ParseLineToFileFilter([rsFilterToolbarFiles, '*.toolbar', rsFilterXmlConfigFiles, '*.xml', rsFilterTCToolbarFiles, '*.BAR', rsFilterAnyFiles, '*.*']);
-  SaveDialog.Filter := ParseLineToFileFilter([rsFilterToolbarFiles, '*.toolbar', rsFilterTCToolbarFiles, '*.BAR', rsFilterAnyFiles, '*.*']);
+  OpenDialog.Filter := ParseLineToFileFilter([rsFilterToolbarFiles, '*.toolbar', rsFilterXmlConfigFiles, '*.xml', rsFilterTCToolbarFiles, '*.BAR', rsFilterAnyFiles, AllFilesMask]);
+  SaveDialog.Filter := ParseLineToFileFilter([rsFilterToolbarFiles, '*.toolbar', rsFilterTCToolbarFiles, '*.BAR', rsFilterAnyFiles, AllFilesMask]);
   FUpdatingButtonType := False;
   FToolDragButtonNumber := -1;
   {$IF LCL_FULLVERSION >= 093100}

src/frames/foptionstooltips.pas

@@ -142,7 +142,7 @@ begin
   bCurrentlyFilling := True;
   ParseLineToList(rsToolTipModeList, cbTooltipShowingMode.Items);
   ParseLineToList(rsToolTipHideTimeOutList, cbToolTipHideTimeOut.Items);
-  OpenTooltipFileTypeDialog.Filter := ParseLineToFileFilter([rsFilterDCToolTipFiles, '*.tooltip', rsFilterAnyFiles, '*.*']);
+  OpenTooltipFileTypeDialog.Filter := ParseLineToFileFilter([rsFilterDCToolTipFiles, '*.tooltip', rsFilterAnyFiles, AllFilesMask]);
   SaveTooltipFileTypeDialog.Filter := OpenTooltipFileTypeDialog.Filter;
 end;
 

src/umaincommands.pas

@@ -5459,7 +5459,7 @@ begin
   //3. If user provided no parameter, let's launch the file requester to have user point a file.
   if Length(Params) = 0 then
   begin
-    dmComData.OpenDialog.Filter:= ParseLineToFileFilter([rsFilterPluginFiles, '*.dsx;*.wcx;*.wdx;*.wfx;*.wlx;*.dsx64;*.wcx64;*.wdx64;*.wfx64;*.wlx64', rsFilterAnyFiles, '*.*']);
+    dmComData.OpenDialog.Filter:= ParseLineToFileFilter([rsFilterPluginFiles, '*.dsx;*.wcx;*.wdx;*.wfx;*.wlx;*.dsx64;*.wcx64;*.wdx64;*.wfx64;*.wlx64', rsFilterAnyFiles, AllFilesMask]);
     dmComData.OpenDialog.InitialDir := frmMain.ActiveNotebook.ActivePage.FileView.CurrentPath;
     if dmComData.OpenDialog.Execute then
       sPluginFilename := dmComData.OpenDialog.FileName;