mirrors/doublecmd
2
0
Fork 0
mirror of https://github.com/doublecmd/doublecmd.git synced 2026-06-28 10:02:14 +00:00
Code Issues Projects Releases Packages Wiki Activity

UPD: When destroying try always to remove file source from manager if possible.

Browse source
This commit is contained in:
cobines 2009-11-02 14:25:08 +00:00
commit d46ef91f04
1 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/newdesign/ufilesource.pas
View file

@ -230,7 +230,17 @@ end;
destructor TFileSource.Destroy;
begin
DebugLn('Destroying ', ClassName, ' when refcount=', DbgS(refcount));
if (RefCount = 0) and Assigned(FileSourceManager) then
if RefCount <> 0 then
begin
// There could have been an exception raised in the constructor
// in which case RefCount will be 1, so only issue warning if there was no exception.
// This will check for any exception, but it's enough for a warning.
if not Assigned(ExceptObject) then
DebugLn('Error: RefCount <> 0 for ', Self.ClassName);
end;
if Assigned(FileSourceManager) then
begin
// Restore reference removed in Create and
// remove the instance remaining in Manager.
@ -250,9 +260,6 @@ begin
else
DebugLn('Error: Cannot remove file source - manager already destroyed!');
if RefCount <> 0 then
DebugLn('Error: RefCount <> 0 for ', Self.ClassName);
inherited Destroy;
end;