mirrors/escargot
2
0
Fork 0
mirror of https://github.com/Samsung/escargot.git synced 2026-06-22 10:01:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

Optmize escargot (#454)

Browse source 
* Don't allocate new StringView on parser if possible
* Store esprima::Context::firstCoverInitializedNameError as pointer. it can reduce copy cost on esprima::*CoverGrammar
* Make Script as reexcutable if possible
* Don't save parsed source codes
  - Remove SourceStringView
  - When create AtomicString from StringView, we should make new string data instead of reference StringView
* Reduce size of StringBufferAccessData
* Fix crash in toString of FunctionObject.

Signed-off-by: seonghyun kim <sh8281.kim@samsung.com>
This commit is contained in:
Patrick Kim 2019-10-11 15:32:04 +09:00 • committed by Hyukwoo Park
commit 03ac100d7f
17 changed files with 163 additions and 255 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/parser/ScriptParser.cpp
View file

@ -206,11 +206,10 @@ ScriptParser::InitializeScriptResult ScriptParser::initializeScript(StringView s
// Parsing
try {
m_context->vmInstance()->m_parsedSourceCodes.push_back(scriptSource.string());
InterpretedCodeBlock* topCodeBlock = nullptr;
RefPtr<ProgramNode> programNode = esprima::parseProgram(m_context, scriptSource, isModule, strictFromOutside, inWith, stackSizeRemain, allowSC, allowSP);
Script* script = new Script(fileName, new StringView(scriptSource), programNode->moduleData());
Script* script = new Script(fileName, new StringView(scriptSource), programNode->moduleData(), !parentCodeBlock);
if (parentCodeBlock) {
programNode->scopeContext()->m_hasEval = parentCodeBlock->hasEval();
programNode->scopeContext()->m_hasWith = parentCodeBlock->hasWith();
@ -249,7 +248,6 @@ ScriptParser::InitializeScriptResult ScriptParser::initializeScript(StringView s
return result;
} catch (esprima::Error& orgError) {
m_context->vmInstance()->m_parsedSourceCodes.pop_back();
GC_enable();
ScriptParser::InitializeScriptResult result;