mirrors/escargot
2
0
Fork 0
mirror of https://github.com/Samsung/escargot.git synced 2026-06-29 10:02:14 +00:00
Code Issues Projects Releases Packages Wiki Activity

Implement OrdinaryHasProperty (O, P), Fix some bugs in ProxyObject (#371)

Browse source 
* Use OrdinaryHasProperty at Object::hasProperty
* Override enumeration for ProxyObject
* Pass more test262 tests
* Exclude test262 tests related to Proxy's enumerate because of that is deprecated in ECMAScript 8.0

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
This commit is contained in:
Boram Bae 2019-08-14 18:25:35 +09:00 • committed by Hyukwoo Park
commit 31dec6a7b9
5 changed files with 64 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/runtime/ProxyObject.cpp
View file

@ -627,6 +627,13 @@ bool ProxyObject::isExtensible(ExecutionState& state)
return booleanTrapResult;
}
void ProxyObject::enumeration(ExecutionState& state, bool (*callback)(ExecutionState& state, Object* self, const ObjectPropertyName&, const ObjectStructurePropertyDescriptor& desc, void* data), void* data, bool shouldSkipSymbolKey)
{
// Note : the enumeration method is not [[Enumerate]] () in spec
// In our implementation, Object::enumeration method should be overridden properly, therefore when calling this functionm, must run enumeration of target
this->target()->enumeration(state, callback, data, shouldSkipSymbolKey);
}
// https://www.ecma-international.org/ecma-262/6.0/#sec-proxy-object-internal-methods-and-internal-slots-setprototypeof-v
bool ProxyObject::setPrototype(ExecutionState& state, const Value& value)
{
@ -808,7 +815,7 @@ ObjectGetResult ProxyObject::get(ExecutionState& state, const ObjectPropertyName
ObjectGetResult targetDesc = target.asObject()->getOwnProperty(state, propertyName);
// 13. If targetDesc is not undefined, then
if (!targetDesc.value(state, target).isUndefined()) {
if (targetDesc.hasValue()) {
// a. If IsDataDescriptor(targetDesc) and targetDesc.[[Configurable]] is false and targetDesc.[[Writable]] is false, then
if (targetDesc.isDataProperty() && !targetDesc.isConfigurable() && !targetDesc.isWritable()) {
// i. If SameValue(trapResult, targetDesc.[[Value]]) is false, throw a TypeError exception.