mirrors/escargot
2
0
Fork 0
mirror of https://github.com/Samsung/escargot.git synced 2026-06-22 10:01:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

Suppress false positve asan stack underflow error

Browse source 
+ hide public symbols if possible

Signed-off-by: Seonghyun Kim <sh8281.kim@samsung.com>
This commit is contained in:
Seonghyun Kim 2020-08-24 11:55:37 +09:00 • committed by Boram Bae
commit 606b59ecef
5 changed files with 29 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
build/config.cmake
View file

@ -173,9 +173,13 @@ SET (ESCARGOT_LDFLAGS_SHAREDLIB -ldl)
# STATIC_LIB FLAGS
SET (ESCARGOT_CXXFLAGS_STATICLIB -fPIC)
SET (ESCARGOT_CXXFLAGS_STATICLIB -fPIC -DESCARGOT_EXPORT=)
SET (ESCARGOT_LDFLAGS_STATICLIB -Wl,--gc-sections)
# SHELL FLAGS
SET (ESCARGOT_CXXFLAGS_SHELL -DESCARGOT_EXPORT=)
SET (ESCARGOT_LDFLAGS_SHELL -Wl,--gc-sections)
#######################################################
# FLAGS FOR TEST

6
src/Escargot.h
View file

@ -144,6 +144,12 @@
#endif
#endif
#if defined(COMPILER_GCC) || defined(COMPILER_CLANG)
#define ATTRIBUTE_NO_SANITIZE_ADDRESS __attribute__((no_sanitize_address))
#else
#define ATTRIBUTE_NO_SANITIZE_ADDRESS
#endif
// #define OS(NAME) (defined OS_##NAME && OS_##NAME)
#ifdef _WIN32

4
src/api/EscargotPublic.h
View file

@ -20,9 +20,9 @@
#ifndef __ESCARGOT_PUBLIC__
#define __ESCARGOT_PUBLIC__
#ifndef ESCARGOT_EXPORT
#if !defined(ESCARGOT_EXPORT)
#if defined(_MSC_VER)
#define ESCARGOT_EXPORT __declspec(dllESCARGOT_EXPORT)
#define ESCARGOT_EXPORT __declspec(dllexport)
#else
#define ESCARGOT_EXPORT __attribute__((visibility("default")))
#endif

21
src/runtime/CompressibleString.cpp
View file

@ -174,6 +174,19 @@ void CompressibleString::decompress()
constexpr static const size_t g_compressChunkSize = 1044465;
static_assert(LZ4_COMPRESSBOUND(g_compressChunkSize) == 1024 * 1024, "");
static ATTRIBUTE_NO_SANITIZE_ADDRESS bool testPointerExistsOnStack(size_t* start, size_t* end, const void* ptr)
{
while (start != end) {
if (UNLIKELY(*start == (size_t)ptr)) {
// if there is reference on stack, we cannot compress string.
return true;
}
start++;
}
return false;
}
template <typename StringType>
bool CompressibleString::compressWorker(void* callerSP)
{
@ -188,12 +201,8 @@ bool CompressibleString::compressWorker(void* callerSP)
size_t* end = (size_t*)((size_t)callerSP & ~(sizeof(size_t) - 1));
#endif
while (start != end) {
if (UNLIKELY(*start == (size_t)m_bufferData.buffer)) {
// if there is reference on stack, we cannot compress string.
return false;
}
start++;
if (testPointerExistsOnStack(start, end, m_bufferData.buffer)) {
return false;
}
size_t originByteLength = m_bufferData.length * sizeof(StringType);

2
test/vendortest

@ -1 +1 @@
Subproject commit 95766bf5a8157ce6b434303ecdbac11e76deb96c
Subproject commit aad8e2f2279ca4583a05cd46c5a1b1efcadb0837