mirrors/escargot
2
0
Fork 0
mirror of https://github.com/Samsung/escargot.git synced 2026-06-22 10:01:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

1. fix setting array length bug

Browse source 
2. optimze reduce array length
3. implement escape, unescape
4. implement rest of Array.prototype builtin functions

this patch pass all of test262(5.1)

Signed-off-by: seonghyun kim <sh8281.kim@samsung.com>
This commit is contained in:
seonghyun kim 2017-01-04 18:19:42 +09:00
commit 9405b56d82
12 changed files with 565 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/runtime/ArrayObject.cpp
View file

@ -42,7 +42,7 @@ bool ArrayObject::defineOwnProperty(ExecutionState& state, const ObjectPropertyN
bool succeeded = Object::defineOwnProperty(state, P, desc);
if (!succeeded)
return false;
if (idx >= oldLen && (idx + 1 < Value::InvalidArrayIndexValue)) {
if (idx >= oldLen && ((idx + 1) <= Value::InvalidArrayIndexValue)) {
return setArrayLength(state, idx + 1);
}
return true;
@ -137,10 +137,6 @@ bool ArrayObject::setArrayLength(ExecutionState& state, const uint64_t& newLengt
{
ASSERT(isExtensible() || newLength <= getArrayLength(state));
if (UNLIKELY(newLength == Value::InvalidArrayIndexValue)) {
ErrorObject::throwBuiltinError(state, ErrorObject::Code::RangeError, errorMessage_GlobalObject_InvalidArrayLength);
}
if (UNLIKELY(isFastModeArray() && (newLength > ESCARGOT_ARRAY_NON_FASTMODE_MIN_SIZE))) {
uint32_t orgLength = getArrayLength(state);
if (newLength > orgLength) {
@ -162,10 +158,21 @@ bool ArrayObject::setArrayLength(ExecutionState& state, const uint64_t& newLengt
while (newLen < oldLen) {
oldLen--;
bool deleteSucceeded = deleteOwnProperty(state, ObjectPropertyName(state, Value(oldLen)));
ObjectPropertyName key(state, Value(oldLen));
if (!getOwnProperty(state, key).hasValue()) {
oldLen = Object::nextIndexBackward(state, this, oldLen, -1, false);
if (oldLen < newLen) {
break;
}
key = ObjectPropertyName(state, Value(oldLen));
}
bool deleteSucceeded = deleteOwnProperty(state, key);
if (!deleteSucceeded) {
m_values[ESCARGOT_OBJECT_BUILTIN_PROPERTY_NUMBER] = Value(oldLen + 1);
// Object::throwCannotDeleteError(state, PropertyName(state, String::fromDouble(oldLen)));
return false;
}
}