CodeSmell - private members (#219)

https://sonarcloud.io/project/issues?branch=travisMoka&id=Achie72_escargot&resolved=false&rules=cpp%3AS3656&severities=CRITICAL

Signed-off-by: bence gabor kis <kisbg@inf.u-szeged.hu>

src/parser/ast/ArrowFunctionExpressionNode.h

@@ -43,7 +43,7 @@ public:
     }
 
     virtual ASTNodeType type() { return ASTNodeType::ArrowParameterPlaceHolder; }
-protected:
+private:
     ExpressionNodeVector m_params;
 };
 

src/parser/ast/SwitchCaseNode.h

@@ -51,7 +51,7 @@ public:
         m_consequent->generateStatementByteCode(codeBlock, context);
     }
 
-protected:
+private:
     RefPtr<ExpressionNode> m_test;
     RefPtr<StatementContainer> m_consequent;
 };

src/parser/ast/SwitchStatementNode.h

@@ -120,7 +120,7 @@ public:
     }
 
     virtual ASTNodeType type() { return ASTNodeType::SwitchStatement; }
-protected:
+private:
     RefPtr<ExpressionNode> m_discriminant;
     RefPtr<StatementContainer> m_casesA;
     RefPtr<StatementNode> m_default;

src/parser/ast/TaggedTemplateExpressionNode.h

@@ -55,7 +55,7 @@ public:
         RELEASE_ASSERT_NOT_REACHED();
     }
 
-protected:
+private:
     RefPtr<Node> m_expr;
     RefPtr<Node> m_quasi;
 };

src/parser/ast/UnaryExpressionDeleteNode.h

@@ -88,7 +88,7 @@ public:
         m_argument->iterateChildrenIdentifier(fn);
     }
 
-protected:
+private:
     RefPtr<ExpressionNode> m_argument;
 };
 }

src/parser/ast/UnaryExpressionMinusNode.h

@@ -51,7 +51,7 @@ public:
         m_argument->iterateChildrenIdentifier(fn);
     }
 
-protected:
+private:
     RefPtr<Node> m_argument;
 };
 }

src/runtime/ArgumentsObject.h

@@ -49,7 +49,7 @@ public:
     void* operator new(size_t size);
     void* operator new[](size_t size) = delete;
 
-protected:
+private:
     FunctionEnvironmentRecord* m_targetRecord;
     InterpretedCodeBlock* m_codeBlock;
     TightVector<std::pair<SmallValue, AtomicString>, GCUtil::gc_malloc_ignore_off_page_allocator<std::pair<SmallValue, AtomicString>>> m_argumentPropertyInfo;

src/runtime/ArrayObject.h

@@ -139,7 +139,7 @@ public:
     void* operator new(size_t size);
     void* operator new[](size_t size) = delete;
 
-protected:
+private:
     Object* m_array;
     size_t m_iteratorNextIndex;
     Type m_type;

src/runtime/GlobalObject.h

@@ -646,7 +646,7 @@ public:
     }
     void* operator new[](size_t size) = delete;
 
-protected:
+private:
     Context* m_context;
 
     FunctionObject* m_object;

src/runtime/Object.h

@@ -390,6 +390,12 @@ private:
     {
         return m_isDataProperty;
     }
+    bool m_isDataProperty : 1;
+    PresentAttribute m_property;
+    union {
+        Value m_value;
+        JSGetterSetter m_getterSetter;
+    };
 
 protected:
     void checkProperty()
@@ -411,12 +417,6 @@ protected:
         }
     }
     MAKE_STACK_ALLOCATED();
-    bool m_isDataProperty : 1;
-    PresentAttribute m_property;
-    union {
-        Value m_value;
-        JSGetterSetter m_getterSetter;
-    };
 };
 
 class ObjectGetResult {