mirrors/escargot
2
0
Fork 0
mirror of https://github.com/Samsung/escargot.git synced 2026-06-29 10:02:14 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix class bugs (#418)

Browse source 
* Fixup class parsing error check in esprima
* Class cannot have property named 'prototype'
* When define {getter, setter} in interpreter, property key can be symbol
* Reorder properties on class constructor
* Fixup public API

Signed-off-by: seonghyun kim <sh8281.kim@samsung.com>
This commit is contained in:
Patrick Kim 2019-09-09 10:12:47 +09:00 • committed by Boram Bae
commit 98d3c9c26e
19 changed files with 222 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

42
src/interpreter/ByteCodeInterpreter.cpp
View file

@ -2999,13 +2999,22 @@ NEVER_INLINE void ByteCodeInterpreter::newTargetOperation(ExecutionState& state,
NEVER_INLINE void ByteCodeInterpreter::defineObjectGetter(ExecutionState& state, ObjectDefineGetter* code, Value* registerFile)
{
// FIXME: FunctionObject
FunctionObject* fn = registerFile[code->m_objectPropertyValueRegisterIndex].asFunction();
String* pName = registerFile[code->m_objectPropertyNameRegisterIndex].toString(state);
StringBuilder builder;
builder.appendString("get ");
builder.appendString(pName);
fn->defineOwnProperty(state, state.context()->staticStrings().name, ObjectPropertyDescriptor(builder.finalize()));
Value pName = registerFile[code->m_objectPropertyNameRegisterIndex];
Value fnName = pName;
if (fnName.isSymbol()) {
StringBuilder builder;
builder.appendString("get [");
builder.appendString(fnName.asSymbol()->description());
builder.appendString("]");
fnName = builder.finalize(&state);
} else {
StringBuilder builder;
builder.appendString("get ");
builder.appendString(fnName.toString(state));
fnName = builder.finalize(&state);
}
fn->defineOwnProperty(state, state.context()->staticStrings().name, ObjectPropertyDescriptor(fnName));
JSGetterSetter gs(registerFile[code->m_objectPropertyValueRegisterIndex].asFunction(), Value(Value::EmptyValue));
ObjectPropertyDescriptor desc(gs, (ObjectPropertyDescriptor::PresentAttribute)(ObjectPropertyDescriptor::ConfigurablePresent | ObjectPropertyDescriptor::EnumerablePresent));
Object* object = registerFile[code->m_objectRegisterIndex].toObject(state);
@ -3014,13 +3023,22 @@ NEVER_INLINE void ByteCodeInterpreter::defineObjectGetter(ExecutionState& state,
NEVER_INLINE void ByteCodeInterpreter::defineObjectSetter(ExecutionState& state, ObjectDefineSetter* code, Value* registerFile)
{
// FIXME: FunctionObject
FunctionObject* fn = registerFile[code->m_objectPropertyValueRegisterIndex].asFunction();
String* pName = registerFile[code->m_objectPropertyNameRegisterIndex].toString(state);
StringBuilder builder;
builder.appendString("set ");
builder.appendString(pName);
fn->defineOwnProperty(state, state.context()->staticStrings().name, ObjectPropertyDescriptor(builder.finalize()));
Value pName = registerFile[code->m_objectPropertyNameRegisterIndex];
Value fnName = pName;
if (fnName.isSymbol()) {
StringBuilder builder;
builder.appendString("set [");
builder.appendString(fnName.asSymbol()->description());
builder.appendString("]");
fnName = builder.finalize(&state);
} else {
StringBuilder builder;
builder.appendString("set ");
builder.appendString(fnName.toString(state));
fnName = builder.finalize(&state);
}
fn->defineOwnProperty(state, state.context()->staticStrings().name, ObjectPropertyDescriptor(fnName));
JSGetterSetter gs(Value(Value::EmptyValue), registerFile[code->m_objectPropertyValueRegisterIndex].asFunction());
ObjectPropertyDescriptor desc(gs, (ObjectPropertyDescriptor::PresentAttribute)(ObjectPropertyDescriptor::ConfigurablePresent | ObjectPropertyDescriptor::EnumerablePresent));
Object* object = registerFile[code->m_objectRegisterIndex].toObject(state);