mirrors/escargot
2
0
Fork 0
mirror of https://github.com/Samsung/escargot.git synced 2026-06-22 10:01:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

implement slow mode of ArrayObject

Browse source 
Signed-off-by: seonghyun kim <sh8281.kim@samsung.com>
This commit is contained in:
seonghyun kim 2016-12-22 12:38:16 +09:00
commit f9a3715ae6
2 changed files with 37 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/runtime/ArrayObject.cpp
View file

@ -27,6 +27,12 @@ bool ArrayObject::defineOwnProperty(ExecutionState& state, const ObjectPropertyN
if (LIKELY(setFastModeValue(state, P, desc))) {
return true;
}
uint32_t idx = P.toValue(state).toArrayIndex(state);
if (idx != Value::InvalidArrayIndexValue) {
setArrayLength(state, idx);
}
return Object::defineOwnProperty(state, P, desc);
}
@ -41,7 +47,7 @@ bool ArrayObject::deleteOwnProperty(ExecutionState& state, const ObjectPropertyN
}
if (LIKELY(idx != Value::InvalidArrayIndexValue)) {
uint32_t len = m_fastModeData.size();
ASSERT(len == getLength(state));
ASSERT(len == getArrayLength(state));
if (idx < len) {
m_fastModeData[idx] = Value(Value::EmptyValue);
return true;
@ -90,4 +96,21 @@ void ArrayObject::iterateArrays(ExecutionState& state, HeapObjectIteratorCallbac
{
iterateSpecificKindOfObject(state, HeapObjectKind::ArrayObjectKind, callback);
}
void ArrayObject::convertIntoNonFastMode(ExecutionState& state)
{
if (!structure()->isStructureWithFastAccess()) {
m_structure = structure()->convertToWithFastAccess(state);
}
ensureObjectRareData()->m_isFastModeArrayObject = false;
for (size_t i = 0; i < m_fastModeData.size(); i++) {
if (!m_fastModeData[i].isEmpty()) {
defineOwnPropertyThrowsExceptionWhenStrictMode(state, ObjectPropertyName(state, Value(i)), ObjectPropertyDescriptor(m_fastModeData[i], ObjectPropertyDescriptor::AllPresent));
}
}
m_fastModeData.clear();
}
}