mirrors/forgejo
2
0
Fork 1
mirror of https://codeberg.org/forgejo/forgejo.git synced 2026-06-22 10:02:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(ui): adjust sidebar distances and remove empty p elements (#12864)

Browse source 
I removed the empty `p` elements for accessibility as mentioned in this https://codeberg.org/forgejo/forgejo/pulls/12786#issuecomment-16247117. I also adjusted the spacing for the "reference" text with the divider to have the copy button have the same spacing as other buttons.

## Testing

Navigate to an issue and observe the spacing of the time tracker, reference and dependencies sections.

<table style="width:100%">
  <tr>
    <td>Before</td>
    <td>After</td>
  </tr>
  <tr>
    <td><img width="250" src="/attachments/a4e14050-1d14-457c-9d4f-ec9ac1ae3bcc" /></td>
    <td><img width="250" src="/attachments/3ab4445c-9f14-49d7-ac77-a7d69e914e58" /></td>
  </tr>
</table>

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12864
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
This commit is contained in:
Dylan Weijgertze 2026-06-01 12:14:01 +02:00 • committed by 0ko
commit f1622c4e85
3 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
templates/repo/issue/view_content/sidebar/due_deadline.tmpl
View file

@ -5,8 +5,7 @@
{{ctx.Locale.Tr "repo.issues.due_date_invalid"}}
</div>
{{if ne .Issue.DeadlineUnix 0}}
<p></p>
<div class="tw-flex tw-justify-between tw-items-center">
<div class="tw-flex tw-justify-between tw-items-center tw-mt-4">
<div class="due-date {{if .Issue.IsOverdue}}text red{{end}}" {{if .Issue.IsOverdue}}data-tooltip-content="{{ctx.Locale.Tr "repo.issues.due_date_overdue"}}"{{end}}>
{{svg "octicon-calendar" 16 "tw-mr-2"}}
{{DateUtils.AbsoluteLong .Issue.DeadlineUnix}}

9
templates/repo/issue/view_content/sidebar/reference.tmpl
View file

@ -10,11 +10,8 @@
{{ctx.Locale.Tr "discussion.sidebar.reference"}}
</strong>
</span>
<p></p>
<div class="ui equal width compact grid">
<div class="row tw-items-center" data-tooltip-content="{{$issueReferenceLink}}">
<span class="text column truncate">{{$issueReferenceLink}}</span>
<button class="ui two wide button column tw-p-2" data-tooltip-content="{{ctx.Locale.Tr "copy"}}" data-clipboard-text="{{$issueReferenceLink}}">{{svg "octicon-copy" 14}}</button>
</div>
<div class="ui tw-flex tw-justify-between tw-items-end tw-mt-1" data-tooltip-content="{{$issueReferenceLink}}">
<span class="text column truncate">{{$issueReferenceLink}}</span>
<button class="ui two wide button column tw-p-2" data-tooltip-content="{{ctx.Locale.Tr "copy"}}" data-clipboard-text="{{$issueReferenceLink}}">{{svg "octicon-copy" 14}}</button>
</div>
</div>

3
templates/repo/issue/view_content/sidebar/timetracking.tmpl
View file

@ -53,8 +53,7 @@
{{end}}
<div class="ui comments">
<span class="text"><strong>{{ctx.Locale.Tr "repo.issues.time_spent_from_all_authors" ($.Issue.TotalTrackedTime | Sec2Time)}}</strong></span>
<p></p>
<div>
<div class="tw-mt-4">
{{range $user, $trackedtime := .WorkingUsers}}
<div class="comment tw-mt-2">
<a class="avatar">