mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-06-22 10:02:15 +00:00
0e283c5485
Turns out this was a one-line fix for each affected field (change the binding from `ValidUrl` to `ValidSiteUrl`), but the tests are rather verbose. The tests are, however, each a simple flow of Create Thing > Try HTTP Website > Try Different Website (notice failure) > Try Different Website With New Config (notice success). I wrote this PR by adding failing tests first, then making the change, for each affected field. Not sure if this should be "feat:" or "fix:" tbh. I figured "fix:" for this PR since IMO the expected behavior is for `VALID_SITE_URL_SCHEMES` to apply in each of these cases, not only for user profiles via the UI form. (Later changed to "feat:" at @limiting-factor's suggestion, based on the observation that this change extends documented behavior.) This PR deals with the server-side validation only. #12991 covers client-side validation (deriving a `pattern` attribute from `VALID_SITE_URL_SCHEMES`, etc.) Closes #5519 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12962 Reviewed-by: limiting-factor <limiting-factor@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| admin.go | ||
| auth_form.go | ||
| avatar.go | ||
| org.go | ||
| package_form.go | ||
| repo_branch_form.go | ||
| repo_form.go | ||
| repo_form_test.go | ||
| repo_tag_form.go | ||
| report_abuse.go | ||
| runner.go | ||
| secret.go | ||
| user_form.go | ||
| user_form_auth_openid.go | ||
| user_form_hidden_comments.go | ||
| user_form_test.go | ||