mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-06-22 10:02:15 +00:00
373c876db6
Reviewing https://codeberg.org/forgejo/forgejo/pulls/12928 inspired me to bridge the gap between our highly advanced markup checkboxes and our other inconsistent UI checkboxes. This PR does exactly that: it re-uses most of already developed code from markup in our regular UI checkboxes. This not only makes them look much better but also brings us closer to getting rid of Fomantic checkboxes. In fact, removing `ui checkbox` from such checkboxes keeps them looking well, and only breaks Fomantic scripts related to them. Some notable changes: - Better vertical alignment - More consistent gap distance between the box and the text - Removed obsolete vendor prefixes in properties - In UI, everything is actually styled by Forgejo now instead of being a mismatch with browser's default styling. Dark theme + Firefox looks a lot better now - In UI, checkmarks are now consistent across browsers ## Preview |Before|After| |-|-| |Markup|Slightly increased gap| ||| |UI|Fixed vert. alignment| ||| ||| |UI dark|Properly styled now| ||| ## Testing No bugs found to fix and automated testing for yet. I went manually through many areas and found none. There's one bad margin in Migrate repo - LFS advanced settings, but it's consistent with mainline. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13016 Reviewed-by: Gusted <gusted@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| animations.css | ||
| breadcrumb.css | ||
| button-legacy.css | ||
| button.css | ||
| card.css | ||
| checkbox.css | ||
| comment.css | ||
| container.css | ||
| dialog.css | ||
| dimmer.css | ||
| divider.css | ||
| dropdown.css | ||
| flexcontainer.css | ||
| grid.css | ||
| hashbox.css | ||
| header.css | ||
| input.css | ||
| label.css | ||
| list.css | ||
| message.css | ||
| modal.css | ||
| navbar.css | ||
| normalize.css | ||
| segment.css | ||
| select.css | ||
| stats-bar.css | ||
| svg.css | ||
| switch.css | ||
| tab.css | ||
| table.css | ||
| tippy.css | ||
| toast.css | ||
| user-cards.css | ||