mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-06-22 10:02:15 +00:00
de5f38c4ea
A handful of routes, described in this PR as "mixed routes", are currently accessible by both web-based sessions and authenticated API users. The goal of this PR is to allow access to these routes for Authorized Integrations as well, bringing them to full API compatibility (to my knowledge) with other authentication methods. These routes are impacted:
- `/{username}/{repo}/raw/*`
- `/{username}/{repo}/archive/*`
- `/{username}/{repo}/releases/download/{vTag}/{fileName}`
- `/{username}/{repo}/attachments/{uuid}`
- `/attachments/{uuid}`
The major work in this PR was to refactoring the existing authentication methods so that "path based matching" that they were currently doing was no longer required, as I didn't want to introduce that into Authorized Integrations. All the path based matching is removed in this PR, and authentication methods are enabled entirely by the middleware applied to their endpoints.
## Checklist
The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).
### Tests for Go changes
- I added test coverage for Go changes...
- [ ] in their respective `*_test.go` for unit tests.
- [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I ran...
- [x] `make pr-go` before pushing
### Documentation
- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.
### Release notes
- [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change.
- [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12776
Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
|
||
|---|---|---|
| .. | ||
| access_token.go | ||
| action_runtime_token.go | ||
| action_runtime_token_test.go | ||
| action_task_token.go | ||
| additional_scopes_test.go | ||
| auth.go | ||
| auth_result_accesstoken.go | ||
| auth_result_actionstask.go | ||
| auth_result_authorized_integration.go | ||
| auth_result_basicpassword.go | ||
| auth_result_httpsign.go | ||
| auth_result_lfs_token.go | ||
| auth_result_oauth.go | ||
| auth_result_reverseproxy.go | ||
| auth_result_session.go | ||
| authorized_integration.go | ||
| authorized_integration_claims.go | ||
| authorized_integration_claims_test.go | ||
| authorized_integration_test.go | ||
| basic.go | ||
| group.go | ||
| httpsign.go | ||
| lfs_token.go | ||
| lfs_token_test.go | ||
| main_test.go | ||
| oauth2.go | ||
| reverseproxy.go | ||
| reverseproxy_test.go | ||
| session.go | ||
| signin.go | ||
| util.go | ||
| util_test.go | ||