mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-06-22 10:02:15 +00:00
eb76582261
This test fails very often in CI. This should hopefully improve it. With a downclocked CPU I've got 2 errors in 10 tries. After adding ``` await page.waitForLoadState(); ``` I got no errors in 20 tries. But my testing methodology is unreliable so there's no guarantee that this helps: * `Locator.click()` documentation says that it already waits by default for caused navigation to finish * I added some `date` time measurement and `waitForLoadState` was clocking in about 5-15 ms, which shouldn't be causing the issue for `expect` that times out in 3000ms ...but e2e issues were `element(s) not found` on timeout, not wrong state, so my assumption is that somehow it is asserting the wrong snapshot of a page that isn't fully loaded Additionally, I've converted _revertion_ logic to _make consistent before testing_, which is better at handling test retries in case that the _revertion_ part of the code was never ran in previous failure. In such case test retry is guaranteed to fail as well, at least when testing locally, not sure about CI. Additionally, a completely unrelated comment fix in Playwright config. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12871 Reviewed-by: Gusted <gusted@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| e2e | ||
| forgery | ||
| fuzz | ||
| gitea-lfs-meta | ||
| gitea-repositories-meta | ||
| integration | ||
| testdata/data | ||
| install.ini.tmpl | ||
| mysql.ini.tmpl | ||
| pgsql.ini.tmpl | ||
| sqlite.ini.tmpl | ||
| test_utils.go | ||
| unittest.ini.tmpl | ||