mirrors/k-skill
2
0
Fork 0
mirror of https://github.com/NomaDamas/k-skill.git synced 2026-06-24 02:04:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cover NCard error branches

Browse source 
Add regression coverage for missing NCard package handling and zero-based NCard selection so the KTX helper keeps clear failures around optional korail2-ncard support.

Constraint: PR #231 adds optional NCard behavior that must still be safe when korail2-ncard is not installed.

Rejected: Changing runtime NCard behavior now | existing implementation already returns explicit SystemExit messages and only lacked regression coverage.

Confidence: high

Scope-risk: narrow

Directive: Keep NCard fallback behavior tested separately from normal korail2 imports.

Tested: python3 -m pytest scripts/test_ktx_booking.py -q

Not-tested: Live Korail NCard reservation against production account.
This commit is contained in:
Jeffrey (Dongkyu) Kim 2026-05-12 19:08:17 +09:00
commit 7a0cefb832
1 changed files with 33 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

33
scripts/test_ktx_booking.py
View file

@ -396,6 +396,39 @@ class KtxBookingTests(unittest.TestCase):
])
self.assertEqual(args.ncard_index, 1)
def test_command_ncard_search_fails_on_zero_index(self):
ncard = FakeNCard()
client = FakeClient([], ncards=[ncard])
args = argparse.Namespace(
dep="대전", arr="서울", date="20260512", time="100000",
ncard_index=0, limit=5, train_type="ktx",
)
with patch.object(ktx_booking, "_NCARD_AVAILABLE", True):
with patch.object(ktx_booking, "build_client", return_value=client):
with self.assertRaises(SystemExit) as exc:
ktx_booking.command_ncard_search(args)
self.assertIn("ncard-index", str(exc.exception))
def test_command_ncard_list_requires_ncard_package(self):
with patch.object(ktx_booking, "_NCARD_AVAILABLE", False):
with self.assertRaises(SystemExit) as exc:
ktx_booking.command_ncard_list(argparse.Namespace())
self.assertIn("korail2-ncard", str(exc.exception))
def test_command_reserve_with_ncard_no_requires_ncard_package(self):
selected = FakeTrain(train_no="009", dep_time="100000", arr_time="105700",
dep_name="대전", arr_name="서울")
train_id = ktx_booking.normalize_train(selected, index=1)["train_id"]
args = self.make_args(train_id, ncard_no="1234567890123456")
args.ncard_index = None
client = FakeClient([selected])
with patch.object(ktx_booking, "_NCARD_AVAILABLE", False):
with patch.object(ktx_booking, "build_client", return_value=client):
with self.assertRaises(SystemExit) as exc:
ktx_booking.command_reserve(args)
self.assertIn("korail2-ncard", str(exc.exception))
def test_command_reserve_with_ncard_no_uses_ncard_passenger(self):
selected = FakeTrain(train_no="009", dep_time="100000", arr_time="105700",
dep_name="대전", arr_name="서울")