Commit graph

6 commits

Author SHA1 Message Date
Jeffrey (Dongkyu) Kim
84b3c993df Validate flight search arguments before bootstrap
Parse CLI arguments before installing the cached fast-flights runtime, add numeric bounds, validate date relationships early, and always use the pinned private runtime instead of arbitrary global installs.

Constraint: PR #224 helper should keep --help and invalid input paths offline and deterministic.

Rejected: Importing any global fast_flights package opportunistically | version drift can break TFS URL generation and query behavior.

Confidence: high

Scope-risk: narrow

Directive: Keep provider execution behind explicit valid commands; do not bootstrap dependencies for help or parser errors.

Tested: python3 -m py_compile flight-ticket-search/scripts/flight_ticket_search.py; FLIGHT_TICKET_SEARCH_BOOTSTRAPPED=1 python3 flight-ticket-search/scripts/flight_ticket_search.py --help; invalid return-date and step-days parser checks; git diff --check

Not-tested: Live Google Flights fetch through fast-flights.
2026-05-12 19:11:29 +09:00
Jeffrey (Dongkyu) Kim
25db06795e Prevent invalid flight queries from bootstrapping runtime
Validate flight-ticket CLI inputs before initializing the fast-flights runtime so bad dates, same-airport routes, and impossible ranges fail quickly without network or environment-dependent setup.

Constraint: PR #224 adds a crawler-style skill whose helper must handle invalid user input conservatively before external provider access.

Rejected: Add broad round-trip comparison support | outside the minimal merge-blocking correctness fix.

Confidence: high

Scope-risk: narrow

Directive: Keep provider/runtime initialization after argparse help and local input validation.

Tested: python3 -m py_compile flight-ticket-search/scripts/flight_ticket_search.py; CLI help and invalid-input smoke checks; ./scripts/validate-skills.sh; npm run typecheck; npm run lint; npm run test

Not-tested: Live Google Flights search because local Homebrew Python has a pyexpat/libexpat linkage failure during dependency bootstrap.

Co-authored-by: OmX <omx@oh-my-codex.dev>
2026-05-12 19:09:19 +09:00
Jeffrey (Dongkyu) Kim
116bb5f58a omx(team): auto-checkpoint worker-5 [5] 2026-05-12 18:59:43 +09:00
Jeffrey (Dongkyu) Kim
300f1c9c93 omx(team): auto-checkpoint worker-5 [5] 2026-05-12 18:58:59 +09:00
Jeffrey (Dongkyu) Kim
043efe7f79 omx(team): auto-checkpoint worker-5 [5] 2026-05-12 18:57:33 +09:00
TaeyoungPark
8f1044046f feat: add flight ticket search skill 2026-05-10 17:40:39 +09:00