mirrors/manim
2
0
Fork 0
mirror of https://github.com/ManimCommunity/manim.git synced 2026-06-22 10:01:47 +00:00
Code Issues Projects Releases Packages Wiki Activity

Various cleanup changes (#795)

Browse source 
* removed inherit from object which is unnecessary in Python3

* raise NotImplemented in abstract method

* refactored imports to maintain consistent style accross files and bring inline with PEP8

* sorted imports

* removed redundant inherit from object on classes

* refactored imports to be consistent accross files and PEP8 complient

* fixed NotImplementedError

* removed redundant inherit from object

* Revert "removed redundant inherit from object"

This reverts commit d9e3cbda49.

* reformatted code with black

* fixed Transform import

* reverted NotImplementedError on interpolate_submobject due to dependancy in class

* retrigger tests

* fixed black to retrigger tests

Co-authored-by: Harry <52263746+Harry-L-01@users.noreply.github.com>
Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
This commit is contained in:
Harry 2020-12-23 14:53:33 +00:00 • committed by GitHub
commit 1ddb2791ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
manim/camera/camera.py
View file

@ -29,7 +29,7 @@ from ..utils.space_ops import get_norm
from ..utils.family import extract_mobject_family_members
class Camera(object):
class Camera:
"""Base camera class.
This is the object which takes care of what exactly is displayed
@ -1148,7 +1148,7 @@ class Camera(object):
# NOTE: The methods of the following class have not been mentioned outside of their definitons.
# Their DocStrings are not as detailed as preferred.
class BackgroundColoredVMobjectDisplayer(object):
class BackgroundColoredVMobjectDisplayer:
def __init__(self, camera):
"""
Parameters

13
manim/camera/three_d_camera.py
View file

@ -8,16 +8,17 @@ import numpy as np
from .. import config
from ..camera.camera import Camera
from ..constants import *
from ..mobject.three_d_utils import get_3d_vmob_end_corner
from ..mobject.three_d_utils import get_3d_vmob_end_corner_unit_normal
from ..mobject.three_d_utils import get_3d_vmob_start_corner
from ..mobject.three_d_utils import get_3d_vmob_start_corner_unit_normal
from ..mobject.three_d_utils import (
get_3d_vmob_end_corner,
get_3d_vmob_end_corner_unit_normal,
get_3d_vmob_start_corner,
get_3d_vmob_start_corner_unit_normal,
)
from ..mobject.types.point_cloud_mobject import Point
from ..mobject.value_tracker import ValueTracker
from ..utils.color import get_shaded_rgb
from ..utils.space_ops import rotation_about_z
from ..utils.space_ops import rotation_matrix
from ..utils.family import extract_mobject_family_members
from ..utils.space_ops import rotation_about_z, rotation_matrix
class ThreeDCamera(Camera):