Address review feedback: move changelog to Changed, use useMemo for addedPackageNames set

Agent-Logs-Url: https://github.com/vrc-get/vrc-get/sessions/3de0d89e-1f21-4b64-8f9e-4869f497f742

Co-authored-by: anatawa12 <22656849+anatawa12@users.noreply.github.com>

CHANGELOG-gui.md

@@ -25,13 +25,13 @@ The format is based on [Keep a Changelog].
 - Path for unitypackage on Template Editor now can be reselected `#2635`
 - ALCOM now refuses launching project if project is on noexec mount points `#2814`
   - This would cause problems with several native plugins
+- Already-added packages are now excluded from the package name suggestions in the Template Editor `#2828`
 
 ### Deprecated
 
 ### Removed
 
 ### Fixed
-- Already-added packages are now excluded from the package name suggestions in the Template Editor `#2828`
 - Fixed an issue where the progress bar flickered and did not display correct progress in environments using WebKit as the renderer. [`#2641`](https://github.com/vrc-get/vrc-get/pull/2641)
 - Fails to import UnityPackages with files in `Packages` directory `#2679`
 - null as vpmDependencies value is not allowed `#2709`

vrc-get-gui/app/_main/packages/templates/index.tsx

@@ -741,6 +741,11 @@ function TemplateEditor({
 		reorderable: false,
 	});
 
+	const addedPackageNames = useMemo(
+		() => new Set(packagesListContext.value.map((p) => p.name)),
+		[packagesListContext.value],
+	);
+
 	const unityPackagesListContext = useReorderableList<string>({
 		defaultValue: "",
 		defaultArray: template?.unity_packages ?? [],
@@ -913,9 +918,7 @@ function TemplateEditor({
 														options={packageCandidates.filter(
 															(c) =>
 																c.value === value.name ||
-																!packagesListContext.value.some(
-																	(p) => p.name === c.value,
-																),
+																!addedPackageNames.has(c.value),
 														)}
 														onChange={(value) =>
 															packagesListContext.update(id, (old) => ({